PERL PERL5 PORTERS 32 PATCH WIN32 MAKEFILES FOR BLEAD TO ALLOW PARAMETERS TO BE PASSED TO HARNESS
Date: Sat, 19 Feb 2005 11:00:08 +0100

Subject: Patch Win32 makefiles for blead to allow parameters to be passed to harness:
From: demerphq@no-spam (Demerphq)

This allows you to do things like:

nmake test TEST="op/pat.t"

And similar. If TEST isnt defined harness runs them all as normal.

Cheers,
Yves
-- First they ignore you, then they laugh at you, then they fight you,
then you win.
+Gandhi
--- ./win32/Makefile.mk=092005-02-18 17:37:42.000000000 +0100
+++ g:\blead_trie/win32/Makefile.mk=092005-02-19 10:57:58.497129600 +0100
@@no-spam -1352,7 +1352,7 @@no-spam .ENDIF =20
test : $(RIGHTMAKE) test-prep -=09cd ..\t && $(PERLEXE) -I..\lib harness +=09cd ..\t && $(PERLEXE) -I..\lib harness $(TEST)
=20
test-notty : test-prep =09set PERL_SKIP_TTY_TEST=3D1 && \
--- ./win32/Makefile=092005-02-18 18:56:17.117382400 +0100
+++ g:\blead_trie/win32/Makefile=092005-02-18 19:14:16.789875200 +0100
@@no-spam -1183,7 +1183,7 @@no-spam =20
test : test-prep =09cd ..\t -=09$(PERLEXE) -I..\lib harness +=09$(PERLEXE) -I..\lib harness $(TEST)
=09cd ..\win32
=20
test-notty : test-prep
[qptext makefile.patch]


Date: Sat, 19 Feb 2005 12:12:49 -0500

Subject: Re: Patch Win32 makefiles for blead to allow parameters to be passed to harness:
From: schwern@no-spam (Michael G Schwern)
On Sat, Feb 19, 2005 at 11:00:08AM +0100, demerphq wrote:
> This allows you to do things like:
> > nmake test TEST="op/pat.t"
> > And similar. If TEST isnt defined harness runs them all as normal.

TEST is too generic. MakeMaker uses TEST_FILES. It wouldn't hurt to remain consistent with that.


Date: Sat, 19 Feb 2005 19:19:49 +0100

Subject: Re: Patch Win32 makefiles for blead to allow parameters to be passed to harness:
From: demerphq@no-spam (Demerphq)
On Sat, 19 Feb 2005 13:10:40 -0500, Michael G Schwern <schwern@no-spam> wrote:
> On Sat, Feb 19, 2005 at 06:47:04PM +0100, demerphq wrote:
> > > TEST is too generic. MakeMaker uses TEST_FILES. It wouldn't hurt to remain
> > > consistent with that.
> >
> > Ok, although it wouldnt just be files. It could be other flags to the > > t/harness script...
> >
> > IE:
> >
> > TEST="-v op/*.t"
> > TEST="-torture"
> > Then TEST_ARGS?

Yeah, that sounds good, althought maybe the following would be even better as it would maintain MakeMaker compat and allow the args to be set independently.

test : test-prep cd ..\t $(PERLEXE) -I..\lib harness $(TEST_ARGS) $(TEST_FILES)
cd ..\win32

(not intended as a patch, just for discussion purposes)

Yves ps: cc'ing P5p again as I forgot to hit reply to all earlier. -- First they ignore you, then they laugh at you, then they fight you,
then you win.
+Gandhi

Date: Sat, 19 Feb 2005 13:42:03 -0500

Subject: Re: Patch Win32 makefiles for blead to allow parameters to be passed to harness:
From: schwern@no-spam (Michael G Schwern)
On Sat, Feb 19, 2005 at 07:19:49PM +0100, demerphq wrote:
> Yeah, that sounds good, althought maybe the following would be even > better as it would maintain MakeMaker compat and allow the args to be > set independently.
> > test : test-prep > cd ..\t > $(PERLEXE) -I..\lib harness $(TEST_ARGS) $(TEST_FILES)
> cd ..\win32
> > (not intended as a patch, just for discussion purposes)

Yeah, I was going to suggest that. In which case, s/TEST_ARGS/TEST_SWITCHES/


Date: Wed, 23 Feb 2005 12:56:13 +0000

Subject: Re: Patch Win32 makefiles for blead to allow parameters to be passed
From: steve.hay@no-spam (Steve Hay)
demerphq wrote:

>This allows you to do things like:
>
> nmake test TEST="op/pat.t"
>
>And similar. If TEST isnt defined harness runs them all as normal.
>
Thanks. Applied to bleadperl as change 23992 (with TEST_SWITCHES and TEST_FILES changes, as suggested later.)

- Steve
------------------------------------------------
Radan Computational Ltd.

The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.