PERL PERL5 PORTERS 44 RE PATCH SIGNED UNSIGNED HELP FOR PP PACK C
Date: Mon, 21 Feb 2005 15:18:27 +0100

Subject: Re: [PATCH] signed/unsigned help for pp_pack.c
From: rgarciasuarez@no-spam (Rafael Garcia-Suarez)

Craig A. Berry wrote:
> The bleadperl build currently fails using Compaq C V6.5-001 on OpenVMS > Alpha V7.3-1 because there are lots of signed/unsigned mismatch warnings > in pp_pack.c. The attached patch adds a bunch of casts to make explicit > the assumption that as long as we shovel 8 bits at a time to the right > place, we don't care about signedness. I don't know enough about the > UTF-8 conversion routines to know if that assumption is really true,
> i.e., that we never manipulate the contents of those bytes in such a way > that sign would matter. The patch does get the build to succeed and > t/op/pack.t also succeeds.

Thanks, applied as #23988 to bleadperl.