PGSQL COMMITTERS 27 PGSQL PREPARE AND EXPLAIN NEED TO COPY THE SOURCE QUERY JUST LIKE WE
From: tgl@no-spam (Tom Lane)
Subject: pgsql: PREPARE and EXPLAIN need to copy the source query just like we
Date: Sun, 12 Dec 2004 20:17:07 +0000 (GMT)


Log Message:
-----------
PREPARE and EXPLAIN need to copy the source query just like we recently had to do in DECLARE CURSOR. AFAICS these are all the places affected.
PREPARE case per example from Michael Fuhr, EXPLAIN case located by grepping for planner calls ...

Modified Files:
--------------
pgsql/src/backend/commands:
explain.c (r1.127 -> r1.128)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/explain.c.diff?r1=1.127&r2=1.128)

prepare.c (r1.34 -> r1.35)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/prepare.c.diff?r1=1.34&r2=1.35)


---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org





From: tgl@no-spam (Tom Lane)
Subject: Re: pgsql: PREPARE and EXPLAIN need to copy the source query just like we
Date: Sun, 12 Dec 2004 19:45:51 -0500

Sean Chittenden <sean@no-spam> writes:
>> PREPARE and EXPLAIN need to copy the source query just like we recently >> had to do in DECLARE CURSOR. AFAICS these are all the places affected.
>> PREPARE case per example from Michael Fuhr, EXPLAIN case located by >> grepping for planner calls ...

> Does this mean that cache lookup failures (most notably in pl/pgsql) > will simply result in a replan as opposed to a query failure and the > transaction being aborted? Or is this a first step in that direction?
No, and no. This has no user-visible impact at all (other than not crashing in cases that should work).

regards, tom lane
---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster