PHP MIRRORS 31 CVS PHP BUGS WEB REPORT PHP
Date: Tue, 01 Jul 2003 13:10:40 -0000

Subject: cvs: php-bugs-web / report.php
From: alindeman@no-spam (Andrew Lindeman)

alindeman Tue Jul 1 09:10:40 2003 EDT
Modified files: /php-bugs-web report.php Log:
fix bug #23529. Add some "js tricks" to add an "Irrelevant"
version option when submitting php.net bugs only.
Index: php-bugs-web/report.php diff -u php-bugs-web/report.php:1.37 php-bugs-web/report.php:1.38
--- php-bugs-web/report.php:1.37 Mon Jun 30 08:30:41 2003
+++ php-bugs-web/report.php Tue Jul 1 09:10:40 2003
@@no-spam -227,6 +227,24 @@no-spam if ($errors) display_errors($errors);
?>
+<script language="javascript" type="text/javascript">
+var irrelevantOn = false;
+
+function handleVersionChange (obj) {
+ if (obj.value == "Website problem") {
+ irrelevantOn = true;
+
+ document.forms[1].elements[2].options[document.forms[1].elements[2].options.length] = new Option("Irrelevant", "Irrelevant", true, true);

+ } else {
+ if (irrelevantOn) {
+ document.forms[1].elements[2].options[document.forms[1].elements[2].options.length - 1] = null;

+ document.forms[1].elements[2].options[0].selected = true;
+ irrelevantOn = false;
+ }
+ }
+}
+</script>
+
<form method="post" action="<?php echo $PHP_SELF;?>">
<input type="hidden" name="in[did_luser_search]" value="<?php echo $in['did_luser_search'] ? 1 : 0; ?>" />

<table>
@@no-spam -243,7 +261,7 @@no-spam </tr><tr>
<th align="right">Type of bug:</th>
<td colspan="2">
- <select name="in[bug_type]"><?php show_types($in['bug_type'],0);?></select>

+ <select name="in[bug_type]" onChange="javascript: handleVersionChange(this)"><?php show_types($in['bug_type'],0);?></select>

</td>
</tr><tr>
<th align="right">Operating system:</th>


Date: Tue, 1 Jul 2003 15:12:51 +0200 (CEST)

Subject: Re: cvs: php-bugs-web / report.php
From: d.rethans@no-spam (Derick Rethans)
On Tue, 1 Jul 2003, Andrew Lindeman wrote:

> alindeman Tue Jul 1 09:10:40 2003 EDT > > Modified files: > /php-bugs-web report.php > Log:
> fix bug #23529. Add some "js tricks" to add an "Irrelevant"
> version option when submitting php.net bugs only.

It would have been nice if this would have been discussed first...

Derick
--
-------------------------------------------------------------------------
Derick Rethans http://derickrethans.nl/ JDI Media Solutions http://www.jdimedia.nl/
International PHP Magazine http://www.php-mag.net/
-------------------------------------------------------------------------


Subject: Re: cvs: php-bugs-web / report.php
Date: 01 Jul 2003 08:15:22 -0500

From: alindeman@no-spam (Andrew Lindeman)
On Tue, 2003-07-01 at 08:12, Derick Rethans wrote:
> On Tue, 1 Jul 2003, Andrew Lindeman wrote:
> > > alindeman Tue Jul 1 09:10:40 2003 EDT > > > > Modified files: > > /php-bugs-web report.php > > Log:
> > fix bug #23529. Add some "js tricks" to add an "Irrelevant"
> > version option when submitting php.net bugs only.
> > It would have been nice if this would have been discussed first...
> > Derick
OK, sorry. In bug #23529, Goba suggested the change, so I figured it was alright.

-- Andrew Lindeman <alindeman@no-spam>


Date: Tue, 1 Jul 2003 16:27:36 +0300 (EEST)

Subject: Re: cvs: php-bugs-web / report.php
From: sniper@no-spam (Jani Taskinen)
Please revert. Just add a new version 'Irrelevant' in the version select box..no need for this JS crap, IMO.
--Jani
On Tue, 1 Jul 2003, Andrew Lindeman wrote:

>alindeman Tue Jul 1 09:10:40 2003 EDT >
> Modified files: > /php-bugs-web report.php > Log:
> fix bug #23529. Add some "js tricks" to add an "Irrelevant"
> version option when submitting php.net bugs only.
> > >Index: php-bugs-web/report.php >diff -u php-bugs-web/report.php:1.37 php-bugs-web/report.php:1.38
>--- php-bugs-web/report.php:1.37 Mon Jun 30 08:30:41 2003
>+++ php-bugs-web/report.php Tue Jul 1 09:10:40 2003
>@@no-spam -227,6 +227,24 @@no-spam > > if ($errors) display_errors($errors);
> ?>
>+<script language="javascript" type="text/javascript">
>+var irrelevantOn = false;
>+
>+function handleVersionChange (obj) {
>+ if (obj.value == "Website problem") {
>+ irrelevantOn = true;
>+
>+ document.forms[1].elements[2].options[document.forms[1].elements[2].options.length] = new Option("Irrelevant", "Irrelevant", true, true);

>+ } else {
>+ if (irrelevantOn) {
>+ document.forms[1].elements[2].options[document.forms[1].elements[2].options.length - 1] = null;

>+ document.forms[1].elements[2].options[0].selected = true;
>+ irrelevantOn = false;
>+ }
>+ }
>+}
>+</script>
>+
> <form method="post" action="<?php echo $PHP_SELF;?>">
> <input type="hidden" name="in[did_luser_search]" value="<?php echo $in['did_luser_search'] ? 1 : 0; ?>" />

> <table>
>@@no-spam -243,7 +261,7 @@no-spam > </tr><tr>
> <th align="right">Type of bug:</th>
> <td colspan="2">
>- <select name="in[bug_type]"><?php show_types($in['bug_type'],0);?></select>

>+ <select name="in[bug_type]" onChange="javascript: handleVersionChange(this)"><?php show_types($in['bug_type'],0);?></select>

> </td>
> </tr><tr>
> <th align="right">Operating system:</th>
>
>

-- https://www.paypal.com/xclick/business=sniper@no-spam

Subject: Re: cvs: php-bugs-web / report.php
Date: 01 Jul 2003 08:34:29 -0500

From: alindeman@no-spam (Andrew Lindeman)
The argument was that people would use "Irrelevant" for other bugs that need a version, if they didn't know their version or were too lazy to find it out. I'll do whatever, but there are worse things already on php.net than this few lines of JS.

--Andrew
On Tue, 2003-07-01 at 08:27, Jani Taskinen wrote:
> Please revert. Just add a new version 'Irrelevant' > in the version select box..no need for this JS crap, IMO.
> > --Jani > > > On Tue, 1 Jul 2003, Andrew Lindeman wrote:
> > >alindeman Tue Jul 1 09:10:40 2003 EDT > >
> > Modified files: > > /php-bugs-web report.php > > Log:
> > fix bug #23529. Add some "js tricks" to add an "Irrelevant"
> > version option when submitting php.net bugs only.
> > > > > >Index: php-bugs-web/report.php > >diff -u php-bugs-web/report.php:1.37 php-bugs-web/report.php:1.38
> >--- php-bugs-web/report.php:1.37 Mon Jun 30 08:30:41 2003
> >+++ php-bugs-web/report.php Tue Jul 1 09:10:40 2003
> >@@no-spam -227,6 +227,24 @@no-spam > > > > if ($errors) display_errors($errors);
> > ?>
> >+<script language="javascript" type="text/javascript">
> >+var irrelevantOn = false;
> >+
> >+function handleVersionChange (obj) {
> >+ if (obj.value == "Website problem") {
> >+ irrelevantOn = true;
> >+
> >+ document.forms[1].elements[2].options[document.forms[1].elements[2].options.length] = new Option("Irrelevant", "Irrelevant", true, true);

> >+ } else {
> >+ if (irrelevantOn) {
> >+ document.forms[1].elements[2].options[document.forms[1].elements[2].options.length - 1] = null;

> >+ document.forms[1].elements[2].options[0].selected = true;
> >+ irrelevantOn = false;
> >+ }
> >+ }
> >+}
> >+</script>
> >+
> > <form method="post" action="<?php echo $PHP_SELF;?>">
> > <input type="hidden" name="in[did_luser_search]" value="<?php echo $in['did_luser_search'] ? 1 : 0; ?>" />

> > <table>
> >@@no-spam -243,7 +261,7 @@no-spam > > </tr><tr>
> > <th align="right">Type of bug:</th>
> > <td colspan="2">
> >- <select name="in[bug_type]"><?php show_types($in['bug_type'],0);?></select>

> >+ <select name="in[bug_type]" onChange="javascript: handleVersionChange(this)"><?php show_types($in['bug_type'],0);?></select>

> > </td>
> > </tr><tr>
> > <th align="right">Operating system:</th>
> >
> >
-- Andrew Lindeman <alindeman@no-spam>


Date: Tue, 1 Jul 2003 15:35:16 +0200 (CEST)

Subject: Re: cvs: php-bugs-web / report.php
From: d.rethans@no-spam (Derick Rethans)
On Tue, 1 Jul 2003, Andrew Lindeman wrote:

> The argument was that people would use "Irrelevant" for other bugs that > need a version, if they didn't know their version or were too lazy to > find it out. I'll do whatever, but there are worse things already on > php.net than this few lines of JS.

That's why we have "Not Enough Info"

Derick
--
-------------------------------------------------------------------------
Derick Rethans http://derickrethans.nl/ JDI Media Solutions http://www.jdimedia.nl/
International PHP Magazine http://www.php-mag.net/
-------------------------------------------------------------------------